Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rust app codegen template #1864

Merged
merged 13 commits into from
Sep 1, 2023
Merged

Conversation

Niraj-Kamdar
Copy link
Contributor

No description provided.

@Niraj-Kamdar Niraj-Kamdar changed the title wip: rust app codegen template feat: add rust app codegen template Aug 23, 2023
@Niraj-Kamdar Niraj-Kamdar force-pushed the nk/add-rs-app-template branch from e25d838 to 14d4ce2 Compare August 29, 2023 14:43
dOrgJelli
dOrgJelli previously approved these changes Aug 30, 2023
dOrgJelli
dOrgJelli previously approved these changes Aug 31, 2023
krisbitney
krisbitney previously approved these changes Sep 1, 2023
Copy link
Contributor

@krisbitney krisbitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

"ipfs:down": "npx polywrap infra down --modules=eth-ens-ipfs"
},
"dependencies": {
"@polywrap/client-js": "~0.12.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not needed right

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can also remove this one right

},
"devDependencies": {
"@types/node": "18.15.0",
"polywrap": "0.11.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can only keep polywrap?

@@ -0,0 +1 @@
v17.9.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be v18.15.0 like all other .nvmrc files in the CLI repo

@@ -0,0 +1,17 @@
[package]
name = "template_plugin_rs"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be "template_app_rs"

@@ -0,0 +1,21 @@
{
"name": "templates-app-rust",
"description": "Polywrap App Rust Template",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for name, description, version

"scripts": {
"build": "npx polywrap codegen",
"test": "ts-node ./src/index.ts",
"ipfs:up": "npx polywrap infra up --modules=eth-ens-ipfs",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forget to remove! before I was using local ipfs in template but then migrate to just cat instead of add and cat

"version": "0.11.2",
"scripts": {
"build": "npx polywrap codegen",
"test": "ts-node ./src/index.ts",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't work

@@ -0,0 +1,30 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file isn't needed

@dOrgJelli dOrgJelli merged commit 7e311f8 into origin-dev Sep 1, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants